Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect handing of remove_label_fields when two labels use the same fields #5836

Closed
juchiast opened this issue Jan 4, 2021 · 0 comments · Fixed by #5974
Closed

Incorrect handing of remove_label_fields when two labels use the same fields #5836

juchiast opened this issue Jan 4, 2021 · 0 comments · Fixed by #5974
Assignees
@juchiast
Labels
sink: loki Anything `loki` sink related type: bug A code related bug.
Milestone
2021-01-04 Xenoma...

Comments

@juchiast
Copy link
Contributor

juchiast commented Jan 4, 2021

After rendering the first label, those fields will be removed and cannot be used later.

https://github.com/timberio/vector/blob/6c8c0499c8e830329f97048521f964310b38e95d/src/sinks/loki.rs#L155-L167
@juchiast juchiast added type: bug A code related bug. sink: loki Anything `loki` sink related labels Jan 4, 2021
@juchiast juchiast added this to the 2021-01-04 Xenomass Well milestone Jan 4, 2021
@juchiast juchiast self-assigned this Jan 4, 2021
@juchiast juchiast mentioned this issue Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juchiast juchiast

Labels
sink: loki Anything `loki` sink related type: bug A code related bug.
Projects
None yet
Milestone
2021-01-04 Xenomass Well
Development

Successfully merging a pull request may close this issue.

fix(loki sink): Fix remove_label_fields vectordotdev/vector
1 participant
@juchiast