Internal request metric histograms labeled as nanoseconds are actually seconds #7372
Labels
domain: metrics
Anything related to Vector's metrics events
domain: networking
Anything related to Vector's networking
domain: observability
Anything related to monitoring/observing Vector
source: internal_metrics
Anything `internal_metrics` source related
type: bug
A code related bug.
Milestone
While debugging #7371
I found these metrics:
These seem to me to just be seconds rather than nanoseconds which also matches what
metrics-rs
seems to do withDuration
values: https://github.com/metrics-rs/metrics/blob/0df7fe15e4b2b3a415379d59f989adb7881fa323/metrics/src/common.rs#L253We should audit other places we are reporting
Duration
values in our metrics to ensure they are properly labeled asseconds
.An alternative is multiply these by 10 * 9 to turn them into nanoseconds. The histogram buckets will need to be updated if we do that.
The text was updated successfully, but these errors were encountered: