Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / remove metric tags transforms #771

Closed
loony-bean opened this issue Aug 19, 2019 · 2 comments · Fixed by #785
Closed

Add / remove metric tags transforms #771

loony-bean opened this issue Aug 19, 2019 · 2 comments · Fixed by #785
Assignees
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events type: feature A value-adding code addition that introduce new functionality.

Comments

@loony-bean
Copy link
Contributor

Rel #524

Adding static tags will allow ingesting useful meta information, such as env, region, etc.

Removing tags will give users control over tagged metric space, and the resources required to store and process it.

Use cases:

  • CloudWatch accepts only 10 tags (aka dimensions); user might want to selectively drop unnecessary tags to make sure important tags are not trimmed
  • DataDog is limiting multiple unique tag combinations; dropping tags will provide means to control this resource
@loony-bean loony-bean added the needs: approval Needs review & approval before work can begin. label Aug 19, 2019
@binarylogic
Copy link
Contributor

binarylogic commented Aug 19, 2019

Yep, we need to solidify our concepts of tags, fields, and how they work across logs and metrics. We brought this up in planning as it is popping up across other work we're doing (#736)

@lukesteensen
Copy link
Member

This sounds good to me. For now, I think we go with the simple, independent version that just works for metrics. Maybe down the line we can do some work to reduce duplication with add_fields, but I wouldn't worry about it for now.

@lukesteensen lukesteensen removed the needs: approval Needs review & approval before work can begin. label Aug 20, 2019
@loony-bean loony-bean self-assigned this Aug 21, 2019
@binarylogic binarylogic added this to the Initial metrics support milestone Sep 7, 2019
@binarylogic binarylogic added type: feature A value-adding code addition that introduce new functionality. and removed type: new feature labels Jun 16, 2020
@binarylogic binarylogic added domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events and removed event type: metric labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: data model Anything related to Vector's internal data model domain: metrics Anything related to Vector's metrics events type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
3 participants