fix(journald source): Handle missing source timestamp #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a source does not give journald a timestamp, the resulting record will be missing the `_SOURCE_REALTIME_TIMESTAMP` field that this source relies on. This patch adds a fallback to `__REALTIME_TIMESTAMP` if the above is not available, which is always present. Signed-off-by: Bruce Guenter <bruce@timber.io>
bruceg
added
type: bug
ktff
approved these changes
Apr 22, 2020
Signed-off-by: Bruce Guenter <bruce@timber.io>
binarylogic
pushed a commit
that referenced
this pull request
Apr 24, 2020
* fix(journald source): Handle missing source timestamp If a source does not give journald a timestamp, the resulting record will be missing the `_SOURCE_REALTIME_TIMESTAMP` field that this source relies on. This patch adds a fallback to `__REALTIME_TIMESTAMP` if the above is not available, which is always present. Signed-off-by: Bruce Guenter <bruce@timber.io>
binarylogic
pushed a commit
that referenced
this pull request
Apr 29, 2020
* fix(journald source): Handle missing source timestamp If a source does not give journald a timestamp, the resulting record will be missing the `_SOURCE_REALTIME_TIMESTAMP` field that this source relies on. This patch adds a fallback to `__REALTIME_TIMESTAMP` if the above is not available, which is always present. Signed-off-by: Bruce Guenter <bruce@timber.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a source does not give journald a timestamp, the resulting record
will be missing the
_SOURCE_REALTIME_TIMESTAMPfield that this sourcerelies on. This patch adds a fallback to
__REALTIME_TIMESTAMPif theabove is not available, which is always present.
Closes #2384
Signed-off-by: Bruce Guenter bruce@timber.io