Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(file source): Even more instrumentation #3436

Merged
merged 1 commit into from Aug 15, 2020

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Aug 13, 2020

Closes #3197
Follow up of #3417

Does:

  • Renames FileFingerprintFailed to FileChecksumFailed, which @binarylogic suggested, as it's more accurate.
  • Adds FileCheckpointed

Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
@ktff ktff added source: file Anything `file` source related type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector labels Aug 13, 2020
@ktff ktff requested a review from MOZGIII August 13, 2020 11:37
@ktff ktff self-assigned this Aug 13, 2020
@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 13, 2020

FileChecksumFailed reveals the implementation details in the interface. We can allow it, since it's under our control and we can always change it to be more in-line with the implementation - but generally speaking, I think the previous name was a better fit for the code point that emits the message.

Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the more events the better!

@ktff ktff merged commit 40d7dd9 into master Aug 15, 2020
@ktff ktff deleted the ktff/file_inst_update branch August 15, 2020 14:59
perfectayush pushed a commit to perfectayush/vector that referenced this pull request Aug 19, 2020
* master: (47 commits)
  chore(topology): Wait for detached sink to finish  (vectordotdev#3450)
  fix(sinks): Wrap StreamSink around TcpSink (vectordotdev#3495)
  chore: remove tower:0.1 (vectordotdev#3481)
  docs(http sink): Fix default for rate_limit_num (vectordotdev#3498)
  chore: update tokio in tls (vectordotdev#3449)
  fix(prometheus source): rewrite parser, improve error handlings  (vectordotdev#3286)
  chore(fix): OSX doesn't have realpath - added it via coreutils to the bootstrap (vectordotdev#3489)
  chore: Minor spelling, grammar and style fixes (vectordotdev#3472)
  chore: update aws_cloudwatch_logs (vectordotdev#3422)
  chore(ci): do not cancel builds on master (vectordotdev#3462)
  chore(ci): Update the target Ubuntu distros for packaging (vectordotdev#3484)
  enhancement(ci): Ship Helm Chart from release CI workflow (vectordotdev#3459)
  chore: remove bytes:0.4 (vectordotdev#3460)
  chore: Fix stoped typo (vectordotdev#3470)
  chore: Update typo in Docker internal event logging
  chore: Remove ARMv7 references
  enhancement(file source): Even more instrumentation (vectordotdev#3436)
  chore: Extract line_agg from file source (vectordotdev#3451)
  fix: doc test in event/metric (vectordotdev#3461)
  enhancement(console sink): Add "text" encoding for metrics (vectordotdev#3434)
  ...
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector source: file Anything `file` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define events for the file source
2 participants