Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability): Update log levels for transforms #4235

Merged
merged 1 commit into from Oct 11, 2020
Merged

feat(observability): Update log levels for transforms #4235

merged 1 commit into from Oct 11, 2020

Conversation

spencergilbert
Copy link
Contributor

Signed-off-by: Spencer Gilbert spencer.gilbert@gmail.com

I've updated the log levels of several transforms to better match why it's being logged.

  • add_tags: both of these logs are emitted when Vector takes the action as configured (only emits overwritten message when overwrite = true)
  • grok_parser: set missing field log to warn based on a quick chat with @binarylogic, conversion failure seems like a warning or maybe even an error?
  • regex_parser: matched behaviour with grok_parser
  • remove_fields: also discussed with @binarylogic - if you're trying to remove a field and it already isn't there, that seems ok
  • rename_events: overwritten is again the configured behaviour like add_tags, warn on missing field as above
  • split: warn on missing again, and another log for converting which I set to warn but could be error?
  • tag_cardinality_limit: these all appear to be logging when the transform is carrying out its task, maybe it could be info though?
  • tokenizer: warn on missing again, and another log for converting which I set to warn but could be error?

Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
@binarylogic
Copy link
Contributor

Thanks!

@binarylogic binarylogic merged commit 48064d0 into vectordotdev:master Oct 11, 2020
@spencergilbert spencergilbert deleted the update-log-levels branch October 12, 2020 01:52
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
)

Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants