enhancement(kubernetes_logs source): Add PodIPs into Pod Metadata event annotations #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeyun
changed the title
eeyun
force-pushed
the
eeyun/k8s_ip_annotation
branch
from
c93197d
to
ede8ca7
Compare
eeyun
changed the title
eeyun
force-pushed
the
eeyun/k8s_ip_annotation
branch
from
ede8ca7
to
d60906a
Compare
eeyun
changed the title
MOZGIII
suggested changes
Nov 6, 2020
There was a problem hiding this comment.
Great PR!
I left some comments in the code, the theme is mostly on eliminating some bits of custom "magic" and gonig with a bit more KISS approach.
There are some generic things that should be addressed:
- when working on the Kubernetes-related code, add a
ci-condition: k8s e2e tests enableto opt-in into CI running end-top-end tests on your PR; for this PR, also enableci-condition: k8s e2e all targetsto run the test suite on more Kubernetes versions (without it tests are only ran at over a small subset of test targets - typically the latest versions); - please add the assertions to the E2E tests, see:
https://github.com/timberio/vector/blob/aade9e6e5c236f454c010e5e7366722ffa9b93b8/lib/k8s-e2e-tests/tests/vector-agent.rs#L438-L452
Keep in mind that E2E tests ensure our code works across all of our supported Kubernetes versions, and since we're not bumping the MSKV, the test code should be adequate for versions 1.14-1.19 (current latest). Ping me if you need help!
MOZGIII
added
ci-condition: k8s e2e all targets
eeyun
force-pushed
the
eeyun/k8s_ip_annotation
branch
from
d60906a
to
29ed44d
Compare
MOZGIII
reviewed
Nov 11, 2020
MOZGIII
reviewed
Nov 11, 2020
MOZGIII
reviewed
Nov 11, 2020
MOZGIII
reviewed
Nov 11, 2020
eeyun
force-pushed
the
eeyun/k8s_ip_annotation
branch
from
29ed44d
to
b401de3
Compare
Signed-off-by: Ian Henry <ianjhenry00@gmail.com>
eeyun
force-pushed
the
eeyun/k8s_ip_annotation
branch
from
b401de3
to
7a8d87a
Compare
MOZGIII
approved these changes
Nov 11, 2020
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…nts (vectordotdev#4887) Signed-off-by: Ian Henry <ianjhenry00@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4740
Will probably need a thorough review @MOZGIII but ultimately pretty trivial. We tap
k8s_openapito get thePodStatusdata that holdsPodIPs. This also bumps the k8s feature level to1_16to support returning both the IPv4 and IPv6 addresses attached to a pod in the case that both things do in fact exist.Signed-off-by: Ian Henry ianjhenry00@gmail.com