fix(tests): Handle early return from influxdb create database #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 7, 2021 16:07
Signed-off-by: Bruce Guenter <bruce@timber.io>
Signed-off-by: Bruce Guenter <bruce@timber.io>
Signed-off-by: Bruce Guenter <bruce@timber.io>
Signed-off-by: Bruce Guenter <bruce@timber.io>
Some times, the influxdb v1 server will return early from creating the database, providing an OK response code before the database is actually created. Subsequent sink calls will then encounter a NOT_FOUND response when trying to write to the database, resulting in a spurious failure. This tests for database existence after creating it by doing an empty write, and looping until that returns NO_CONTENT. Signed-off-by: Bruce Guenter <bruce@timber.io>
bruceg
added
type: bug
Signed-off-by: Bruce Guenter <bruce@timber.io>
jszwedko
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Nice! Looks good. I like the approach of looping until it is available.
I do think it'd be good to cap the loop so tests don't hang forever in extreme circumstances. You might just be able to use test_util::wait_for_duration? https://github.com/timberio/vector/blob/411100307f44d1d73933b0080dca1da254cd914d/src/test_util/mod.rs#L297-L309
src/sinks/influxdb/mod.rs
Outdated
| // accept writes to the database, leading to test failures. Test | ||
| // this with empty writes and loop if it reports the database | ||
| // does not exist yet. | ||
| loop { |
There was a problem hiding this comment.
I think it'd be good to have this loop break after, say, 10 iterations (5 seconds) to avoid this test hanging forever.
Signed-off-by: Bruce Guenter <bruce@timber.io>
jszwedko
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the influxdb v1 server will return early from creating the
database, providing an OK response code before the database is actually
created. Subsequent sink calls will then encounter a NOT_FOUND response
when trying to write to the database, resulting in a spurious failure.
This tests for database existence after creating it by doing an empty
write, and looping until that returns NO_CONTENT.
Closes #5612
Signed-off-by: Bruce Guenter bruce@timber.io