Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticsearch): Default doc_type to _doc and make it optional #695

Merged
merged 2 commits into from Aug 1, 2019

Conversation

LucioFranco
Copy link
Contributor

Description

Closes #471

@binarylogic looks like the docs already reflected this change, so I did not update them.

Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
Copy link
Contributor

@binarylogic binarylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good.

@LucioFranco LucioFranco merged commit 9675b51 into master Aug 1, 2019
@LucioFranco LucioFranco deleted the doc-type-optional branch August 1, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default elasticsearch sink doc_type to _doc
2 participants