enhancement(ci): support in helm vector-agent to specify command

[martinlevesque]

Ability to specify a command to the daemonsets containers. This is required to pass secrets with berglas (https://github.com/GoogleCloudPlatform/berglas) with Google Secret Manager (see here https://github.com/GoogleCloudPlatform/berglas/tree/main/examples/kubernetes#limitations )

[martinlevesque]

@binarylogic @JeanMertz Hi guys, could you let me know if the pull request makes sense, and if there is anything to improve? Need to have it to be able to set this parameter, otherwise vector cannot be used with berglas to store secrets. Having it working by manually updating the yamls, but it's not ideal, better to use the helm.

[spencergilbert]

@binarylogic @JeanMertz Hi guys, could you let me know if the pull request makes sense, and if there is anything to improve? Need to have it to be able to set this parameter, otherwise vector cannot be used with berglas to store secrets. Having it working by manually updating the yamls, but it's not ideal, better to use the helm.

Sorry for the delay - I'll take a look at this tonight.

I think the CI failure just needs the ./scripts/helm-template-snapshot.sh update run? I'm not super familiar with that section so I'll try and confirm with my review.

[spencergilbert]

I was right about the update command - at least locally. ./scripts/helm-template-snapshot.sh update then check exits 0, I check if this is documented in the contributing doc

[spencergilbert]

@martinlevesque this looks fine and works - but I'm wondering if we need to add support to customize the args as well? Does just updating the command work for you? I'm having some trouble locally - what does your working config look like?

[martinlevesque]

 @spencergilbert Yes it's probably better to add support for both cmd and args, with valid default values. Just updating the command worked. I didn't really test the helm chart thus, tested by changing the daemonset manually.

The daemonset I used is the following (only pasting the relevant part):

spec:
  minReadySeconds: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app.kubernetes.io/instance: xxx
      app.kubernetes.io/name: vector-agent
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/instance: xxx
        app.kubernetes.io/name: vector-agent
        vector.dev/exclude: "true"
    spec:
      containers:
      - args:
        - --config
        - /etc/vector/*.toml
        command:
        - /usr/bin/vector

[spencergilbert]

@martinlevesque would you mind updating the helm-snapshots with ./scripts/helm-template-snapshot.sh update and I'll open another issue to allow configuration of the args as well?

[martinlevesque]

@martinlevesque would you mind updating the helm-snapshots with ./scripts/helm-template-snapshot.sh update and I'll open another issue to allow configuration of the args as well?

@spencergilbert any idea why i'm getting the following:

$ ./scripts/helm-template-snapshot.sh update
Error: unknown flag: --create-namespace
helm.go:76: [debug] unknown flag: --create-namespace

[spencergilbert]

@martinlevesque just checked locally and it looks to be a Helm v2 vs Helm v3 thing - It works with Helm v3.5.4.

I'm going to plan some work to review/update the documentation and the scripts

[martinlevesque]

@spencergilbert i don't have that version currently unfortunately. Just added your account as collaborator in the cloned repository

[martinlevesque]

@spencergilbert awesome, thx!

[spencergilbert]

Merging since this can't affect the benchmarks