fix(observability): missing tracing context on HTTP client metrics #8007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
blt
approved these changes
Jun 23, 2021
spencergilbert
approved these changes
Jun 23, 2021
jszwedko
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we create a dedicated
httpspan when building an instance ofHttpClient<B>that gets wrapped around subsequent usages of the client, such as when sending a request. However, based on where we create this span -- when buildingHttpClient<B>itself -- and how we use it -- instrumenting request futures directly -- we never capture the current span context at the time of when the request is made, which leads to all internal metrics that happen in that request lacking labels.This PR simply eschews the at-creation-time span and instead generates the
httpspan when the request is being constructed.Signed-off-by: Toby Lawrence toby@nuclearfurnace.com