New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws service): Allow zero size compressed messages #8069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
ktff
added
source: aws_kinesis_firehose
Anything `aws_kinesis_firehose` source related
source: aws_s3
Anything `aws_s3` source related
labels
Jun 29, 2021
Signed-off-by: ktf <krunotf@gmail.com>
jszwedko
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! @ktff
bruceg
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, though peekable might simplify one part.
001wwang
pushed a commit
to 001wwang/vector
that referenced
this pull request
Jul 7, 2021
) * AWS S3 Signed-off-by: ktf <krunotf@gmail.com> * aws kinesis firehose Signed-off-by: ktf <krunotf@gmail.com> * Empty message Signed-off-by: ktf <krunotf@gmail.com> * Use vec Signed-off-by: ktf <krunotf@gmail.com> * Correct tests Signed-off-by: ktf <krunotf@gmail.com> * Bump Signed-off-by: ktf <krunotf@gmail.com> * Bump Signed-off-by: ktf <krunotf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
source: aws_kinesis_firehose
Anything `aws_kinesis_firehose` source related
source: aws_s3
Anything `aws_s3` source related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7710
Enable for individually compressed messages to be empty for sources:
aws_kinesis_firehose
aws_s3
Other sources either don't have sub messages or they can't be individually compressed.