Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar charts enhancements #253

Merged
merged 15 commits into from Jun 3, 2023
Merged

Bar charts enhancements #253

merged 15 commits into from Jun 3, 2023

Conversation

clayrat
Copy link
Contributor

@clayrat clayrat commented May 31, 2023

Supersedes #161, fixes #214 and #223.

This PR contains:

  • A fix for incorrect logscale axis label rendering
  • Customized labels on individual bars (based on Add data point labels #161)
  • Ability to use a logscale axis with bar charts
  • Ability to render horizontal bar charts
  • Ability to have internal ticks on an indexed axis (e.g., to render grids)
  • Various linter fixes
  • A test demonstraring horizontal logscale bar with custom labels and an index grid

@clayrat
Copy link
Contributor Author

clayrat commented Jun 1, 2023

Here's the output of the new test demonstrating added functionality:
test20

@clayrat
Copy link
Contributor Author

clayrat commented Jun 2, 2023

@timbod7 @bravit what do you think?

@timbod7
Copy link
Owner

timbod7 commented Jun 3, 2023

Oh - dear. I just took a look at #161, and see that it ended in me saying I'd take a look in a few days. in 2017!

@timbod7
Copy link
Owner

timbod7 commented Jun 3, 2023

A great set of changes. Thank you!

@timbod7 timbod7 merged commit c61aca7 into timbod7:master Jun 3, 2023
@timbod7 timbod7 mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels for log scale axis are not readable at all
3 participants