Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG no-tty helper script and options #1018

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

asfaltboy
Copy link
Member

@asfaltboy asfaltboy commented Sep 23, 2018

As in #596, this change documents a proper GPG setup on tty-enabled OS (Linux/MacOS), and correct credentials docs. This commit also adds the global_pre_flags setting to allow specifying options BEFORE the command, such as the "-c" git per-command config option.

The GPG prompt will only work in Sublime if user sets up git config with the options:

gpg.program=./scripts/stgpg.sh
commit.gpgsign=true

or instead of last one, passes the -S flag to commit command. So, I added the options in the GitSavvy settings comments.

TODO / Discuss:

  • Figure how to use the script file from the packaged zip. Maybe create the file in the User folder on launch?
  • Should we do this by default? Or only if user specifies an option? Or leave it in settings / docs?
  • gpg-agent could freeze (happened to me while importing a key), breaking the whole commit flow, until it's killed. Should we take responsibility for this and warn users?

@randy3k
Copy link
Collaborator

randy3k commented Oct 1, 2018

I guess we could merge this PR first and evaluate its usefulness.

@randy3k
Copy link
Collaborator

randy3k commented Oct 1, 2018

For the record, I use MacGPG and its gpg works in non tty software.

@asfaltboy
Copy link
Member Author

I think without at least documenting it, it won't be of much use. Sorry I didn't get a chance to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants