Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch is passed through kwargs #690

Merged
merged 1 commit into from
Jul 12, 2017
Merged

branch is passed through kwargs #690

merged 1 commit into from
Jul 12, 2017

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Jul 11, 2017

fix #689


The maintainers of this repo require that all pull request submitters agree and adhere to the following:

  • I have read and agree to the contribution guidelines.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Jul 11, 2017

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2017-07-11T18:23:40.661Z:439da81: The pull request was created
  • 2017-07-11T18:25:04.111Z:b7198fa: @randy3k checked I have read and agree to the [contribution guidelines](https://github.com/divmain/GitSavvy/blob/master/CONTRIBUTING.md)..
  • 2017-07-11T18:25:13.755Z:b7198fa: @randy3k checked All related documentation has been updated to reflect the changes made. _(required)_.
  • 2017-07-11T18:25:14.317Z:b7198fa: @randy3k checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-07-11T18:25:24.658Z:b7198fa: @randy3k selected patch as the semantic version.
  • 2017-07-11T18:25:26.120Z:b7198fa: @randy3k deselected patch as the semantic version.
  • 2017-07-11T18:25:28.901Z:b7198fa: @randy3k selected patch as the semantic version.
  • 2017-07-11T18:28:25.783Z:b7198fa: @randy3k deselected patch as the semantic version.
  • 2017-07-11T18:28:26.632Z:b7198fa: @randy3k selected patch as the semantic version.

@randy3k
Copy link
Collaborator Author

randy3k commented Jul 11, 2017

not sure how the semantic versioning in maintainerd works. Do I just select patch?

Copy link
Collaborator

@divmain divmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divmain
Copy link
Collaborator

divmain commented Jul 12, 2017

Yes, just make the appropriate semver selection, and the tag will be auto-incremented and pushed after the PR is merged to master.

@divmain divmain merged commit e51c47a into master Jul 12, 2017
@divmain divmain deleted the randy3k/fix_cherrypick branch July 12, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git: cherrypick is not working
2 participants