Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency error with react-virtual #330

Open
HamedMP opened this issue Aug 18, 2023 · 11 comments · May be fixed by #348
Open

Dependency error with react-virtual #330

HamedMP opened this issue Aug 18, 2023 · 11 comments · May be fixed by #348

Comments

@HamedMP
Copy link

HamedMP commented Aug 18, 2023

I still get an error when I install packages based on react 18 even though #222. Do you have any ideas how to solve it?

npm i --force
npm WARN using --force Recommended protections disabled.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-virtual@2.10.4
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   react@"18.2.0" from the root project
npm WARN   29 more (@headlessui/react, @radix-ui/react-collection, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN node_modules/kbar/node_modules/react-virtual
npm WARN   react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN   node_modules/kbar
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN   node_modules/kbar/node_modules/react-virtual
npm WARN     react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN     node_modules/kbar
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
@HamedMP HamedMP mentioned this issue Aug 18, 2023
Open
@thienguen
Copy link 

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-virtual@2.10.4
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   peer react@"^16.8 || ^17.0 || ^18.0" from @radix-ui/react-compose-refs@1.0.1
npm WARN   node_modules/@radix-ui/react-compose-refs
npm WARN     @radix-ui/react-compose-refs@"1.0.1" from @radix-ui/react-slot@1.0.2
npm WARN     node_modules/@radix-ui/react-slot
npm WARN   45 more (@radix-ui/react-context, @radix-ui/react-dialog, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN node_modules/kbar/node_modules/react-virtual
npm WARN   react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN   node_modules/kbar
npm WARN
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN   node_modules/kbar/node_modules/react-virtual
npm WARN     react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN     node_modules/kbar

Encountered the same error, I tried several attempts to override or npm-force-resolution but was not able to fix it.

As far as I know, there is no breaking effect towards the usage of kbar, but it would be nice to get rid of the warning messages

@danmindru
Copy link

with npm 9+ you can define dep overrides for a workaround:

package.json

  ...
  "overrides": {
    "react": "18.2.0"
  },

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

@thienguen
Copy link

with npm 9+ you can define dep overrides for a workaround:

package.json

  ...
  "overrides": {
    "react": "18.2.0"
  },

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

This works to get rid of the warning but sadly most my projects followed the LTS version of nodejs and npm. Thanks tho!

@ahmadbilaldev
Copy link

Facing the same warning. Is there anything we can do to help fix this?

iFreilicht added a commit to iFreilicht/kbar that referenced this issue Dec 10, 2023
@iFreilicht
Upgrade to react-virtual 3.0.1
6ec8750 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
@iFreilicht iFreilicht linked a pull request Dec 10, 2023 that will close this issue
Open
@iFreilicht
Copy link

I created #348 to fix this.

@ahmadbilaldev If you want to help, test that PR in your project and see if you can find any issues.

iFreilicht added a commit to iFreilicht/kbar that referenced this issue Dec 10, 2023
@iFreilicht
Upgrade to react-virtual 3.0.1
a19a064 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
Haarolean added a commit to Haarolean/kbar that referenced this issue Jan 12, 2024
@Haarolean
Squashed commit of the following:
d1ed626 
commit 51879c7
Author: Felix Uhl <github@mail.felix-uhl.de>
Date:   Sun Dec 10 17:15:24 2023 +0100

    Fix type error

commit a19a064
Author: Felix Uhl <github@mail.felix-uhl.de>
Date:   Sun Dec 10 15:29:40 2023 +0100

    Upgrade to react-virtual 3.0.1

    react-virtual is now available as v3 and published under
    @tanstack/react-virtual. The old version will not receive updates
    anymore, see cloudscape-design/components#1765 (comment).

    Fixes timc1#330
iFreilicht added a commit to iFreilicht/kbar that referenced this issue Mar 2, 2024
@iFreilicht
Upgrade to react-virtual 3.0.1
f64c0b2 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
iFreilicht added a commit to iFreilicht/kbar that referenced this issue Mar 2, 2024
@iFreilicht
Upgrade to react-virtual 3.1.3
b049707 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
iFreilicht added a commit to iFreilicht/kbar that referenced this issue Mar 2, 2024
@iFreilicht
Upgrade to react-virtual 3.1.3
b7da1ca 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
iFreilicht added a commit to iFreilicht/kbar that referenced this issue Mar 2, 2024
@iFreilicht
Upgrade to react-virtual 3.1.3
3d39454 
react-virtual is now available as v3 and published under
@tanstack/react-virtual. The old version will not receive updates
anymore, see cloudscape-design/components#1765 (comment).

Fixes timc1#330
@stale Stale
Copy link

stale bot commented Apr 10, 2024

Hey! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 10, 2024
@iFreilicht
Copy link

Bad bot. Issue persists, PR to fix it was opened already.

@stale stale bot removed the wontfix This will not be worked on label Apr 11, 2024
@SaadFarooq-Dev
Copy link

Please if we can get this fixed.
Thanks

@ketangupta34
Copy link

PLease maintain this and get this fixed

@ketangupta34
Copy link

need some noise here!

@SaadFarooq-Dev
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to react-virtual 3.0.1 iFreilicht/kbar
7 participants
@danmindru @HamedMP @iFreilicht @ahmadbilaldev @ketangupta34 @SaadFarooq-Dev @thienguen