Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): add React v18 support #222

Merged
merged 2 commits into from
Jun 17, 2022
Merged

chore(dependencies): add React v18 support #222

merged 2 commits into from
Jun 17, 2022

Conversation

caiotracera
Copy link
Contributor

@caiotracera caiotracera commented May 31, 2022

Adding react and react-dom ^18.0.0 as peerDependencies to avoid dependency conflicts.

@vercel
Copy link

vercel bot commented May 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kbar ✅ Ready (Inspect) Visit Preview May 31, 2022 at 2:01PM (UTC)

@timc1
Copy link
Owner

timc1 commented Jun 17, 2022

Thanks @caiotracera!

@timc1 timc1 merged commit ba8c1e3 into timc1:main Jun 17, 2022
@vadimdemedes
Copy link

npm still reports errors, because kbar depends on the old react-virtual version which doesn't allow react@18.x in its peer dependencies → https://github.com/TanStack/virtual/blob/v2.10.4/package.json#L47.

@HamedMP
Copy link

HamedMP commented Aug 18, 2023

I also still get an error when I install packages based on react 18. Any ideas how to solve it?

npm i --force
npm WARN using --force Recommended protections disabled.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-virtual@2.10.4
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   react@"18.2.0" from the root project
npm WARN   29 more (@headlessui/react, @radix-ui/react-collection, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN node_modules/kbar/node_modules/react-virtual
npm WARN   react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN   node_modules/kbar
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm WARN   node_modules/kbar/node_modules/react-virtual
npm WARN     react-virtual@"^2.8.2" from kbar@0.1.0-beta.43
npm WARN     node_modules/kbar
npm ERR! code ENOTEMPTY
npm ERR! syscall rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants