New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle combine #55
Merged
Merged
Handle combine #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined `MakeReady` and `Handle` for single await promises while still allowing the stack to unwind.
…sVisibleTo("ProtoPromiseTests", AllInternalsVisible = true)]` for unit tests since finalizers are unreliable. Fixed progress tests. Cleaned up duplicate progress code and made some virtual calls direct.
Update `BackgroundSynchronizationContext` to add `WaitForAllThreadsToComplete()`. Refactored `ThreadHelper` to use `TestHelper._backgroundContext`.
…necessary (but ends up releasing the PromiseRef after the callback instead of before, which can be fixed later for non-catch and non-continuewith). Removed `ProtoPromiseTests\Threading\ForOldRuntime` folder from tests csproj. Updated CircleCI config to use `AllowStackToUnwind` instead of `DeveloperMode`.
This reverts commit a179685.
…xt, even after progress has already completed.
…k properly after the refactor). Reverted CircleCI config to test against DeveloperMode instead of AllowStackToUnwind.
…behavior instead of the execution scheduler, and removed `ILinked<IProgressInvokable>` fields.
timcassell
force-pushed
the
handle-combine
branch
from
March 2, 2022 05:58
5c7ec29
to
b6564e3
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeReady
andHandle
while still allowing the stack to unwind. Potential performance improvements #26Promise(<T>)
s when T is a small struct.async Promise
continuation to execute on the same thread as the last awaited object.Current master:
This PR: