Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse Back button should go back to search results instead of inbox #293

Closed
jairoZX opened this issue Sep 22, 2021 · 21 comments
Closed

Mouse Back button should go back to search results instead of inbox #293

jairoZX opened this issue Sep 22, 2021 · 21 comments
Labels

Comments

@jairoZX
Copy link

jairoZX commented Sep 22, 2021

OS
Linux

Gmail Desktop Version
3.0.0-27 and 2.25.3

Describe the bug
After using the search box in gmail, and using the mouse back button it should go back to the search results and not the inbox, basically same behaviour as the back arrow on gmail

Steps to reproduce the behaviour

  1. search for an email on the inbox
  2. click on an email
  3. press back button on the mouse
  4. goes back to

Expected behaviour
Go back to search results ( gmail does that on the browser)

@jairoZX jairoZX added the bug label Sep 22, 2021
@mgray88
Copy link

mgray88 commented Sep 29, 2021

I'm on macOS and my mouse back button doesn't seem to work at all

@timche
Copy link
Owner

timche commented Feb 12, 2022

@jairoZX @mgray88 is this still an issue with the latest version v3.0.0-alpha.31? Unfortunately I can't reproduce it on macOS and works as described in the expected behaviour.

Also @mgray88 which mouse are you using?

Memo: Also can't reproduce it on Windows.

@mgray88
Copy link

mgray88 commented Feb 14, 2022

@timche Unfortunately yea. I have the Logitech MX Master 2S

@jairoZX
Copy link
Author

jairoZX commented Feb 14, 2022

@timche same here, tried and same thing happen it goes back to inbox not the search results.

I am on Linux (Ubuntu 21.10)

@mgray88
Copy link

mgray88 commented Feb 14, 2022

Interesting, mine doesn't even do that. Just doesn't do anything :(

@timche
Copy link
Owner

timche commented Feb 15, 2022

@mgray88 are the side buttons working in a browser?

@jairoZX it sounds like the navigation behaves differently on Linux.

@mgray88
Copy link

mgray88 commented Feb 15, 2022

@timche Yep, they work pretty much everywhere else I would expect them to work. If it helps, Logitech has a software helper for their hardware, Logitech Options

@timche
Copy link
Owner

timche commented Feb 15, 2022

@jairoZX @mgray88 can you please test the build available here, whether back/forward buttons work and if they work as expected (only going back/forward once in history). If not, can you please open the console in the developer tools and try clicking back/forward buttons and copy-paste the mousedown and mouseup logs here?

@jairoZX
Copy link
Author

jairoZX commented Feb 15, 2022

@timche back and forward buttons works for me now on search, thank you 👍

@mgray88
Copy link

mgray88 commented Feb 15, 2022

@timche Interesting, those two buttons aren't sending any mouseup/down events

@mgray88
Copy link

mgray88 commented Feb 15, 2022

Additionally I can't swipe left with my trackpad, and ⌘ ← (command-left) doesn't work either

@timche
Copy link
Owner

timche commented Feb 15, 2022

@mgray88 thanks for the feedback. There's no support for swiping, but shortcut could be added.

@mgray88
Copy link

mgray88 commented Feb 15, 2022

Command-(left/right) works in other browsers (I've only tested Chromium browsers but I would guess it's pretty standard)

@timche
Copy link
Owner

timche commented Feb 16, 2022

@mgray88 related issue: microsoft/vscode#88029

@timche
Copy link
Owner

timche commented Feb 16, 2022

@mgray88 you could consider trying SensibleSideButtons: https://sensible-side-buttons.archagon.net/

@timche
Copy link
Owner

timche commented Feb 16, 2022

@jairoZX can you please test this build too?

@jairoZX
Copy link
Author

jairoZX commented Feb 16, 2022

tested, also works for back/forward @timche

@timche timche closed this as completed Feb 16, 2022
@MattKetmo
Copy link

Hello, I've just downloaded version 3.0.0-alpha.37 on macOS and I notice neither ⌘ ← nor mouse back button work.

Is anyone having the same issue?
Just trying to understand if it's a regression or something wrong with my setup.

@JohnLGalt
Copy link

I'm on Windows, not MacOS, but also on Alpha build 37, and after searching, and entering any email in the list, back button on my mouse takes me right back to the list of emails.

And once I've opened an email, after going back to the list, pressing forward takes me back to the email I was just looking at as well.

@MattKetmo
Copy link

MattKetmo commented Aug 22, 2023

Indeed the app-command event used here for back & forward navigation is only compatible with Windows & Linux.

Seems the only way to make it work on Mac is to add an explicit keyboard listener.

I'll make a PR for this.

Edit: oops, my link above concerns the main branch not the alpha. So not sure how it works for windows & linux 🤔

@JohnLGalt
Copy link

Could it be something built into Electron?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants