Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Kleio URL like kleio://user:token@localhost:8088/path_to_kleio_home #33

Open
joaquimrcarvalho opened this issue Feb 17, 2024 · 1 comment
Open

Accept Kleio URL like kleio://user:token@localhost:8088/path_to_kleio_home #33

joaquimrcarvalho opened this issue Feb 17, 2024 · 1 comment
Assignees
@joaquimrcarvalho
Labels
enhancement New feature or request
Milestone
1.1 Broad noteboo...

Comments

@joaquimrcarvalho
Copy link
Contributor 

        TODO:

timelink-py/timelink/kleio/kleio_server.py

Line 118 in 8c72535

return KleioServer(url=url, token=token, kleio_home=kleio_home)

@joaquimrcarvalho joaquimrcarvalho self-assigned this Feb 26, 2024
@joaquimrcarvalho
Copy link
Contributor Author

This should be handled by KleioServer.attach() or KleioServer.fromUrl() but not in the init since we don't create objects in init

@joaquimrcarvalho joaquimrcarvalho added the enhancement New feature or request label Feb 26, 2024
@joaquimrcarvalho joaquimrcarvalho changed the title Accept Kleio URL like http://user:token@localhost:8088/path_to_kleio_home Accept Kleio URL like kleio://user:token@localhost:8088/path_to_kleio_home Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaquimrcarvalho joaquimrcarvalho

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1 Broad notebook support
Development

No branches or pull requests
1 participant
@joaquimrcarvalho