Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older Gopro camers (i.e. Hero 5) #129

Closed
FFMbyBicycle opened this issue May 15, 2023 · 4 comments
Closed

Support for older Gopro camers (i.e. Hero 5) #129

FFMbyBicycle opened this issue May 15, 2023 · 4 comments
Labels
enhancement New feature or request possibly-fixed Maybe fixed already, but I can't test it or would like confirmation

Comments

@FFMbyBicycle
Copy link

Currently only newer recordings are supported as the older ones use a different file naming. I didn't want to rename my video (series), so I made a few small fixes and added more regex voodoo in filenaming.py to add support for the older file naming scheme (see lower part here: https://community.gopro.com/t5/en/GoPro-Camera-File-Naming-Convention/ta-p/390220 ) while keeping newer ones working.

Do you want me to add a PR for this? I tried to understand the tests, but I'm not that deep into Python and failed at that step. It would be really nice if we could add that support for everybody 👍

@time4tea
Copy link
Owner

hiya - thanks for the suggestion and code - this is only used in the gopro-rename program - you should be able to to use gopro-dashboard unchanged.... is that your intention?

@time4tea time4tea added the enhancement New feature or request label May 22, 2023
@FFMbyBicycle
Copy link
Author

Sorry, I may have to be more precise: I tried to use gopro-join, which also uses the code and it failed to work with older Gopro videos. That's why I added the fix. gopro-dashboard itself worked fine as far as I remember.

@time4tea
Copy link
Owner

time4tea commented May 26, 2023

ok - so 0.96.0 should have this fix. I can't really test it with real data, but please let me know how it goes. It might take a few minutes to show up in PyPI.

@time4tea time4tea added the possibly-fixed Maybe fixed already, but I can't test it or would like confirmation label May 26, 2023
@FFMbyBicycle
Copy link
Author

Thanks! It seems to work for most cases, which is fine for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request possibly-fixed Maybe fixed already, but I can't test it or would like confirmation
Projects
None yet
Development

No branches or pull requests

2 participants