Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure: put assertions inside an It() #8

Merged
merged 1 commit into from
Dec 3, 2014
Merged

Fix test failure: put assertions inside an It() #8

merged 1 commit into from
Dec 3, 2014

Conversation

nathany
Copy link
Contributor

@nathany nathany commented Nov 26, 2014

If you're using Ginkgo then you probably forgot to put your assertion in an It().

@nathany
put assertions inside an It()
ab7f596 
> If you're using Ginkgo then you probably forgot to put your assertion in an It().
@nathany nathany changed the title put assertions inside an It() Fix test failure: put assertions inside an It() Nov 26, 2014
@nathany
Copy link
Contributor Author

nathany commented Nov 26, 2014

There are still some timeout errors in the tests. If I log the error in runLoop() it appears to be a problem with the dummy certificate:

2014/11/26 12:16:11 remote error: unknown certificate authority
2014/11/26 12:16:11 dial tcp 127.0.0.1:50007: connection refused
2014/11/26 12:16:12 dial tcp 127.0.0.1:50008: connection refused
2014/11/26 12:16:12 dial tcp 127.0.0.1:50009: connection refused
2014/11/26 12:16:12 remote error: unknown certificate authority
2014/11/26 12:16:12 dial tcp 127.0.0.1:50007: connection refused
2014/11/26 12:16:13 remote error: unknown certificate authority
2014/11/26 12:16:13 dial tcp 127.0.0.1:50008: connection refused

@nathany nathany mentioned this pull request Nov 26, 2014
Closed
@bdotdub
Copy link
Contributor

bdotdub commented Dec 3, 2014

Whoops 😁. Merging!

bdotdub added a commit that referenced this pull request Dec 3, 2014
@bdotdub
Merge pull request #8 from nathany/fix_tests
e214012 
Fix test failure: put assertions inside an It()
@bdotdub bdotdub merged commit e214012 into timehop:master Dec 3, 2014
@nathany nathany mentioned this pull request Dec 3, 2014
Merged
@nathany
Copy link
Contributor Author

nathany commented Dec 3, 2014

Thanks. Maybe Ginkgo changed something in a newer version to cause that, I don't know.

I'm still not sure about the certificate authority tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nathany @bdotdub