Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tables.py:2-8: Write test for creating and editing... #234

Closed
0pdd opened this issue Feb 12, 2019 · 17 comments
Closed

test_tables.py:2-8: Write test for creating and editing... #234

0pdd opened this issue Feb 12, 2019 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@0pdd
Copy link

0pdd commented Feb 12, 2019

The puzzle 169-076d68de from #169 has to be resolved:

@todo #169:30min Write test for creating and editing Table model. To test
it correctly it's needed to create relations like `TableShape` and so on
in tests. There is`factory-boy` library in requirements added. It helps
to create instance with its relations automatically, look at
`tests/factories.py` and see
https://factoryboy.readthedocs.io/en/latest/orms.html#sqlalchemy. Implement
these factories for related models and then write tests.

The puzzle was created by Emiliano Della Casa on 12-Feb-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented Feb 12, 2019

@emilianodellacasa/z please, pay attention to this issue

@emilianodellacasa emilianodellacasa added the bug Something isn't working label Feb 12, 2019
@0crat 0crat added the scope Issue is in scope label Feb 12, 2019
@0crat
Copy link

0crat commented Feb 12, 2019

Job #234 is now in scope, role is DEV

@0crat
Copy link

0crat commented Feb 12, 2019

The job #234 assigned to @Vatavuk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link

0crat commented Feb 18, 2019

@Vatavuk/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@Vatavuk
Copy link
Contributor

Vatavuk commented Feb 18, 2019

@emilianodellacasa need a little help. The issue specifies that we need to use Factory Boy factories in order to fake relationships in IT tests. I don't think this is necessary at IT level, nor do we have nullable=False relationship fields that forces us to do so. Should I just add create/edit/delete test like we have in oder tests without factories to speed things up? We can add them later if we find usage for them. If not, I believe we need to update all other IT tests with factories to be consistent.

@Vatavuk
Copy link
Contributor

Vatavuk commented Feb 18, 2019

@0crat wait for arc comment

@0crat 0crat added the waiting Waiting requested label Feb 18, 2019
@0crat
Copy link

0crat commented Feb 18, 2019

@0crat wait for arc comment (here)

@Vatavuk The impediment for #234 was registered successfully by @Vatavuk/z

@emilianodellacasa
Copy link
Contributor

@Vatavuk let's take the faster approach, if we will ever need FactoryBot we will add it

Vatavuk pushed a commit to Vatavuk/timelessis-1 that referenced this issue Feb 19, 2019
Vatavuk pushed a commit to Vatavuk/timelessis-1 that referenced this issue Feb 19, 2019
Vatavuk pushed a commit to Vatavuk/timelessis-1 that referenced this issue Feb 19, 2019
Vatavuk pushed a commit to Vatavuk/timelessis-1 that referenced this issue Feb 21, 2019
Vatavuk pushed a commit to Vatavuk/timelessis-1 that referenced this issue Feb 22, 2019
@0pdd
Copy link
Author

0pdd commented Feb 22, 2019

The puzzle 169-076d68de has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Author

0pdd commented Feb 22, 2019

@0pdd the puzzle #381 is still not solved.

@0crat 0crat removed waiting Waiting requested scope Issue is in scope labels Feb 22, 2019
@0crat
Copy link

0crat commented Feb 22, 2019

Job #234 is not in the agenda of @Vatavuk/z, can't inspect

@0crat
Copy link

0crat commented Feb 22, 2019

The job #234 is now out of scope

@0crat
Copy link

0crat commented Feb 22, 2019

@ypshenychka/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link

0crat commented Feb 24, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @Vatavuk/z

@0crat
Copy link

0crat commented Feb 24, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Author

0pdd commented Jul 15, 2022

@0pdd the puzzle #unknown is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants