Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace NA with Unknown #9

Closed
timelyportfolio opened this issue Apr 29, 2018 · 6 comments
Closed

replace NA with Unknown #9

timelyportfolio opened this issue Apr 29, 2018 · 6 comments

Comments

@timelyportfolio
Copy link
Owner

Logic for NA is very deeply embedded into the design and data transforms. @scheng87, would it be possible to define NA in some other way and not change to "Unknown"?

@scheng87
Copy link

How about if the filter label was for "Unknown" but the data remained as an NA?

@timelyportfolio
Copy link
Owner Author

@scheng87, yes so I did with all filters except geo which is a little more complicated. I will try to add by end of day.

@timelyportfolio
Copy link
Owner Author

I am nervous while we are in rapid iteration to change geo NA to Unknown. For the moment, I would rather have it working than not.

@scheng87
Copy link

scheng87 commented May 12, 2018 via email

@timelyportfolio
Copy link
Owner Author

#34 resolved the NA geo, so I think safe to close.

@scheng87
Copy link

scheng87 commented Jul 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants