Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically resize based on the container #3

Open
jjallaire opened this issue Mar 19, 2015 · 2 comments
Open

dynamically resize based on the container #3

jjallaire opened this issue Mar 19, 2015 · 2 comments

Comments

@jjallaire
Copy link

I started roughing out a dimple widget a few months ago and as part of that figured out how to correctly sync up with the dimple resizing mechanisms. Here was my code:

https://github.com/jjallaire/dimple/blob/master/inst/htmlwidgets/dimple.js#L11-L45

The basic idea was to create the svg element with 100%, 100% sizing and then call chart.draw(0, true) on resize.

@timelyportfolio
Copy link
Owner

Yes I have this experimental faceting that interferes with the built in dimple resizing. Thinking strongly about taking out and handling faceting differently where this code will work well. Thanks. Didn't know you worked on dimple.

@timelyportfolio
Copy link
Owner

@jjallaire I forgot to also include the link to the lines where the sizing is very similar to the proposed. The only difference is these lines create the svg directly rather than dimple, and then the sizing methodology gets whacky as I try to handle the facets inside the svg using g elements in a grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants