Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nginx access log analysis example #686

Merged
merged 36 commits into from
May 7, 2024

Conversation

ayewo
Copy link
Contributor

@ayewo ayewo commented Apr 30, 2024

PR checklist:

  • Did you run ClangFormat ? N/A
  • Did you separate headers to a different section in existing community code base ? N/A
  • Did you surround proton: starts/ends for new code in existing community code base ? N/A

@ayewo ayewo force-pushed the blog/nginx-access-log-streaming branch from f918e9d to 185106d Compare April 30, 2024 23:53
@ayewo
Copy link
Contributor Author

ayewo commented Apr 30, 2024

Hi again @jovezhong,

I've added another article to the examples. Hope you'll take a look 😉 .

@jovezhong
Copy link
Contributor

Nice! I will check it soon. ETA: end of this week, if not sooner.

@jovezhong jovezhong self-requested a review May 1, 2024 00:00
Copy link
Contributor

@jovezhong jovezhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ayewo , this is certainly in the right direction. This is my first batch of the comments. Look forwards to more examples of how to use Timeplus Proton to understand the blog visit pattern in the past, troubleshotting/tuning, and even understand what's going on right now.

examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
examples/nginx-access-logs-streaming/README.md Outdated Show resolved Hide resolved
@ayewo ayewo force-pushed the blog/nginx-access-log-streaming branch 3 times, most recently from def7de4 to 3b429ea Compare May 6, 2024 23:48
@ayewo
Copy link
Contributor Author

ayewo commented May 7, 2024

@jovezhong
Added significantly more content, along with some code.

This is ready for review.

Copy link
Contributor

@jovezhong jovezhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for putting things together. I left some comments. One nice to have thing is to use Grafana proton datasource plugin to visualize the SQL result, or use metabase plugin. But optional for sure.

@ayewo
Copy link
Contributor Author

ayewo commented May 7, 2024

I struggled with getting a column in the access log to be parsed correctly as a datetime64. I wanted to parse the below into 2024-04-24 15:49:59:

SELECT parseDateTime('24/Apr/2024:15:49:59 +0000', '%d/%b/%Y:%H:%i:%s %z');

Works fine on ClickHouse: https://play.clickhouse.com/play?user=play#U0VMRUNUIHBhcnNlRGF0ZVRpbWUoJzI0L0Fwci8yMDI0OjE1OjQ5OjU5ICswMDAwJywgJyVkLyViLyVZOiVIOiVpOiVzICV6Jyk7Cgo=

It seems Proton doesn't yet support theparse_date_time() function?

@jovezhong
Copy link
Contributor

Hi @ayewo , regarding parsing '24/Apr/2024:15:49:59 +0000', can you create a new GitHub issue or discussion? We will implement it soon.

@lizhou1111
Copy link
Collaborator

Hi @ayewo , regarding parsing '24/Apr/2024:15:49:59 +0000', can you create a new GitHub issue or discussion? We will implement it soon.

#688

Copy link
Contributor

@jovezhong jovezhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refinement for blog/images/code. Look good to me. I will merge it now.

@jovezhong jovezhong force-pushed the blog/nginx-access-log-streaming branch from 27c6219 to 4fd1584 Compare May 7, 2024 21:53
@jovezhong jovezhong merged commit c81b845 into timeplus-io:develop May 7, 2024
1 check passed
@jovezhong
Copy link
Contributor

/tip 225

Copy link

algora-pbc bot commented May 7, 2024

Copy link

algora-pbc bot commented May 7, 2024

🎉🎈 @ayewo has been awarded $225! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants