listen on ipv6 address #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` # Default values - try listen localhost on IPv4 and IPv6. # listen_host: '::1' # listen_host: 127.0.0.1 ```
|
Any chance to merge it this week to improve the CLI UX? |
let's listen for 0.0.0.0 instead default localhost/127.0.0.1 1. to keep same behaviour when use docker (either mapping ports or not) 2. to make CI passed before this pr: we only listen for 0.0.0.0 (ipv4) after commit 58da5b5: we listen for 127.1 and [::] actually we need: listen for 0.0.0.0 and [::]
yokofly
approved these changes
May 26, 2024
|
this pr is ready, i verified in my local it works |
jovezhong
approved these changes
May 26, 2024
chenziliang
commented
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/endsfor new code in existing community code base ?Please write user-readable short description of the changes:
Fix #720