Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Drop Extension is Broken #95

Closed
jgpruitt opened this issue Mar 1, 2022 · 4 comments
Closed

Drop Extension is Broken #95

jgpruitt opened this issue Mar 1, 2022 · 4 comments
Assignees
@JamesGuthrie
Labels
Bug Something isn't working
Milestone
0.5.0

Comments

@jgpruitt
Copy link
Collaborator

jgpruitt commented Mar 1, 2022 •
edited

Fix broken TestInstallFlagPromscaleExtension

DROP EXTENSION promscale; causes:

ERROR:  XX000: cache lookup failed for relation 0
LOCATION:  getRelationIdentity, objectaddress.c:5860
@jgpruitt jgpruitt self-assigned this Mar 1, 2022
@jgpruitt jgpruitt added the Bug Something isn't working label Mar 1, 2022
@JamesGuthrie
Copy link
Collaborator

I've opened an issue in the tsdb repo for this: timescale/timescaledb#4140.

It looks like we should be able to work around this issue by manually inserting the correct values into pg_depend.

@cevian do you think that we should a) wait for the fix in TSDB, or b) work around the issue with a manual pg_depend entry?

I think that option b makes more sense:

  1. decouples us from TSDB release process
  2. means that we're not dependent on most recent TSDB (only 2.5.2+)

JamesGuthrie added a commit to timescale/promscale that referenced this issue Mar 8, 2022
@JamesGuthrie
WIP: Skip test which exposes inability to drop extension
8355f69 
Tracking issue: timescale/promscale_extension#95
jgpruitt pushed a commit to timescale/promscale that referenced this issue Mar 9, 2022
@JamesGuthrie @jgpruitt
WIP: Skip test which exposes inability to drop extension
e0df385 
Tracking issue: timescale/promscale_extension#95
jgpruitt pushed a commit to timescale/promscale that referenced this issue Mar 11, 2022
@JamesGuthrie @jgpruitt
WIP: Skip test which exposes inability to drop extension
5e783e6 
Tracking issue: timescale/promscale_extension#95
jgpruitt pushed a commit to timescale/promscale that referenced this issue Mar 11, 2022
@JamesGuthrie @jgpruitt
WIP: Skip test which exposes inability to drop extension
89c9463 
Tracking issue: timescale/promscale_extension#95
@cevian cevian added this to the 0.5.0 milestone Mar 11, 2022
@cevian
Copy link
Contributor

cevian commented Mar 11, 2022

@JamesGuthrie option b sounds fine to me

@jgpruitt
Copy link
Collaborator Author

@cevian looks like the fix is done. Do we know when the next tsdb release is? Should we still try to code around it?

@JamesGuthrie JamesGuthrie mentioned this issue Mar 17, 2022
Merged
2 tasks
@jgpruitt jgpruitt changed the title Fix broken TestInstallFlagPromscaleExtension Drop Extension is Broken Apr 11, 2022
JamesGuthrie added a commit that referenced this issue Apr 13, 2022
@JamesGuthrie
Add DROP EXTENSION to test
2434526 
Before timescaledb 2.6.1 it was not possible to drop the extension. Now
that we've bumped to 2.6.1 we can add a test case.

Fixes #95
@JamesGuthrie JamesGuthrie mentioned this issue Apr 13, 2022
Merged
@JamesGuthrie JamesGuthrie self-assigned this Apr 13, 2022
JamesGuthrie added a commit that referenced this issue Apr 13, 2022
@JamesGuthrie
Add DROP EXTENSION to test
9083ae6 
Before timescaledb 2.6.1 it was not possible to drop the extension. Now
that we've bumped to 2.6.1 we can add a test case.

Fixes #95
@JamesGuthrie
Copy link
Collaborator

We've upgraded to timescaledb 2.6.1 and added a test for this, so the extension can now be dropped 🎉

jgpruitt pushed a commit that referenced this issue Apr 13, 2022
@JamesGuthrie @jgpruitt
Add DROP EXTENSION to test
aabcb65 
Before timescaledb 2.6.1 it was not possible to drop the extension. Now
that we've bumped to 2.6.1 we can add a test case.

Fixes #95
cevian pushed a commit that referenced this issue May 11, 2022
@JamesGuthrie @cevian
Add DROP EXTENSION to test
bb622c4 
Before timescaledb 2.6.1 it was not possible to drop the extension. Now
that we've bumped to 2.6.1 we can add a test case.

Fixes #95
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesGuthrie JamesGuthrie

Labels
Bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@cevian @JamesGuthrie @jgpruitt