Improve tools/build flexibility for local builds. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
epgts
commented
Mar 16, 2022
epgts
commented
- Add parameters for path to pg_config and server TCP port.
- Run local sql-doctester, not whatever is installed.
- Add parameters for path to pg_config and server TCP port. - Run local sql-doctester, not whatever is installed.
epgts
commented
Mar 30, 2022
| require_pgversion() { | ||
| [ -n "$pgversion" ] || die 'specify one of -pg12 | -pg13 | -pg14' | ||
| require_pg_version() { | ||
| [ -n "$pg_version" ] || die 'specify one of -pg12 | -pg13 | -pg14' |
There was a problem hiding this comment.
Here we have pure renames
| echo $1) | ||
| pg_config="$HOME/.pgx/$full_version/pgx-install/bin/pg_config" | ||
| find_pg_config() { | ||
| if [ -z "$pg_config" ]; then |
There was a problem hiding this comment.
Here we add a check if pg_config is already specified before looking for it in ~/.pgx (which remains the default and what we use under the github action).
| pgport=288$pgversion | ||
| pg_version=${arg#-pg} | ||
| pg=pg$pg_version | ||
| [ -z "$pg_port" ] && pg_port=288$pg_version |
There was a problem hiding this comment.
Similarly, only use pgx's port numbering scheme if port wasn't already specified.
WireBaron
approved these changes
Apr 15, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.