Return INTERVAL from duration_in(TEXT, StateAgg). #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epgts
commented
Mar 28, 2022
epgts
commented
Mar 28, 2022
epgts
force-pushed
the
eg/state-interval
branch
from
2c995f7
to
b82c73f
Compare
epgts
changed the title
epgts
force-pushed
the
eg/state-interval
branch
from
b82c73f
to
8c9eb4b
Compare
WireBaron
reviewed
Mar 30, 2022
extension/src/state_aggregate.rs
Outdated
| @@ -279,11 +292,13 @@ mod tests { | |||
| None, | |||
| ); | |||
| assert_eq!( | |||
| 31536120000000, | |||
| "8760:02:00", | |||
There was a problem hiding this comment.
Presumably we wouldn't want to call out to postgres for every timestamptz calculation, but it is worth considering that this a bit different from the postgres result:
postgres=# select ('2020-12-31 00:02:00+00'::timestamptz - '2020-01-01 00:00:00+00'::timestamptz)::interval;
interval
-------------------
365 days 00:02:00
(1 row)
There was a problem hiding this comment.
Oh that's interesting! So it's the responsibility of the caller to do the math and fill out all fields of Interval?! What a pain. I'll look into it. Maybe I'm just holding it wrong.
Thanks!
There was a problem hiding this comment.
It took me a while to figure out how and where postgresql is doing this, but I did find it, and I've documented it here, and I'm calling the same function.
Thanks!
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.