Allow building CI image in Actions #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLockerman
force-pushed
the
jl/build-ci-image-action
branch
2 times, most recently
from
7b4ca5e
to
8fabb70
Compare
jerryxwu
reviewed
May 6, 2022
.github/workflows/ci_image_build.yml
Outdated
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
@JLockerman Is this the place that we should be explicit about version of ubuntu that we want to stick to rather than the latest?
There was a problem hiding this comment.
@jerryxwu 🤔 this is only ever used to build the docker image, so I'm not sure how much it matters either way
There was a problem hiding this comment.
@jerryxwu I'll pin 20.04 under the assumption that it's slightly more likely to keep working that way
This commit adds a GitHub action to build and deploy our CI image. This will any of us to rebuild and deploy the CI image, and test it better before deployment.
JLockerman
force-pushed
the
jl/build-ci-image-action
branch
from
8fabb70
to
bfbdd1b
Compare
rtwalker
approved these changes
May 6, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a GitHub action to build and deploy our CI image. This will any of us to rebuild and deploy the CI image, and test it better before deployment.