Don't install pgx as root or under /
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting some permission denied errors on cargo install commands that I think are related to having pgx installed in / (and running the cargo install pgx commands as the root user instead of user "postgres"). Our solution is to put all of the `cargo ...` statements after `USER postgres` and moving the pgx installations from `/pgx/0.X` to `/home/postgres/pgx/0.X`
epgts
reviewed
May 17, 2022
| @@ -34,28 +31,31 @@ RUN set -ex \ | |||
| && cd timescaledb \ | |||
| && git checkout 2.5.x \ | |||
| && cd ~/timescaledb \ | |||
| && ./bootstrap -DPG_CONFIG=~/.pgx/12.10/pgx-install/bin/pg_config -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DUSE_OPENSSL=false -DSEND_TELEMETRY_DEFAULT=false -DREGRESS_CHECKS=false \ | |||
| && ./bootstrap -DPG_CONFIG=~/.pgx/12.11/pgx-install/bin/pg_config -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DUSE_OPENSSL=false -DSEND_TELEMETRY_DEFAULT=false -DREGRESS_CHECKS=false \ | |||
There was a problem hiding this comment.
Was wondering how long it'd be until something broke after the minor versions were all bumped :)
epgts
approved these changes
May 17, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #408, almost all of the CI tests are failing with permission denied errors, e.g. here, when trying to compile crates after running
cargo test.This PR changes the CI Docker image to:
/pgx/0.Xto/home/postgres/pgx/0.X