remove PATH hack in tools/build script
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epgts
reviewed
May 25, 2022
rtwalker
force-pushed
the
rw/update-pgx-cleanup
branch
from
abcaf0f
to
f2a4dfe
Compare
rtwalker
force-pushed
the
rw/update-pgx-cleanup
branch
from
f2a4dfe
to
a9bd3fb
Compare
epgts
reviewed
May 26, 2022
epgts
reviewed
May 26, 2022
rtwalker
changed the title
tools/build script
rtwalker
force-pushed
the
rw/update-pgx-cleanup
branch
from
a9bd3fb
to
09cd716
Compare
epgts
approved these changes
May 27, 2022
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"license/cla\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
rtwalker
force-pushed
the
rw/update-pgx-cleanup
branch
from
09cd716
to
7d303cc
Compare
We added this in order for #408 to pass the CI tests. Our CI image had pgx 0.2 on its PATH, but since we were upgrading to 0.4, we wanted to use the 0.4 series pgx when running our CI tests (which use `tools/build`). This allowed us to pass our CI tests, but now that we've merged the upgrade, we don't need this, and it surely isn't useful to anyone running tests with `tools/build` locally.
rtwalker
force-pushed
the
rw/update-pgx-cleanup
branch
from
7d303cc
to
91b5f75
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also needed to change
tools/buildfor #408 to pass CI, but we should remove once it's merged.