Improve error message for HyperLogLog #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLockerman
force-pushed
the
jl/hll-errors
branch
from
8af11c9
to
adb3d37
Compare
WireBaron
reviewed
Jun 17, 2022
WireBaron
approved these changes
Jun 22, 2022
This commit improves the error message on attempting to build a HLL with and invalid size. It may be better to move the check earlier, so that it errors even on null input, but this commit holds off on doing so as that would be a breaking change.
JLockerman
force-pushed
the
jl/hll-errors
branch
from
adb3d37
to
cd0bd40
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error message on attempting to build a HLL with and invalid size. It may be better to move the check earlier, so that it errors even on null input, but this commit holds off on doing so as that would be a breaking change.