Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize timevector #488

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Stabilize timevector #488

merged 4 commits into from
Aug 11, 2022

Conversation

WireBaron
Copy link
Contributor

This change moves the timevector function and object out of the toolkit_experimental schema. It also adds a template issue for feature stabilization.

@epgts
Copy link
Contributor

epgts commented Aug 9, 2022

update tests still failing with "ERROR: function timevector(timestamp with time zone, double precision) does not exist", which I can reproduce locally.

Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Also looks like an opportune time to rustfmt all the mod time_vector files :)

extension/src/stabilization_info.rs Show resolved Hide resolved
epgts added a commit that referenced this pull request Aug 9, 2022
Extracted out of Brian's commit ffef4f1 on PR #488.
epgts added a commit that referenced this pull request Aug 11, 2022
Extracted out of Brian's commit ffef4f1 on PR #488.
@WireBaron
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

@bors bors bot merged commit 9a6109a into main Aug 11, 2022
@bors bors bot deleted the br/timevec_stable branch August 11, 2022 23:05
@WireBaron
Copy link
Contributor Author

Ugh, rushed through this and failed to notice that my last push where I formatted time_vector.rs and squashed my commits failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants