Allow approx_count accessor to take NULL inputs
#568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #567 The `approx_count` function previously unwrapped it's aggregate argument without handling the NULL case. With this change, it will instead return NULL when given a NULL for the CountMinSketch.
rtwalker
force-pushed
the
rw/approx-count-nulls
branch
from
5600c13
to
3fbc005
Compare
syvb
approved these changes
Oct 7, 2022
|
bors r+ |
up to you :) |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
The
approx_countfunction previously unwrapped it's aggregate argument without handling the NULL case. With this change, it will instead return NULL when given a NULL for the CountMinSketch.