Stabilizing approx percentile array #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatzopoulos
force-pushed
the
th/approx-percentile-array-stabilization
branch
from
80ff9cc
to
0d54b82
Compare
syvb
approved these changes
Apr 3, 2023
WireBaron
approved these changes
Apr 3, 2023
| @@ -14,6 +14,9 @@ crate::functions_stabilized_at! { | |||
| "1.16.0" => { | |||
| approx_count_distinct(anyelement), | |||
| approx_count_distinct_trans(internal,anyelement), | |||
| accessorpercentilearray_in(cstring), | |||
| accessorpercentilearray_out(accessorpercentilearray), | |||
| arrow_uddsketch_approx_percentile_array(uddsketch,accessorpercentilearray), | |||
There was a problem hiding this comment.
This last function shouldn't go here, the entry you added for STABLE_OPERATORS should cover it. Do you get an error without this entry?
There was a problem hiding this comment.
If I delete that line, the test fails with:
unexpectedly released features: [
"function arrow_uddsketch_approx_percentile_array(uddsketch,accessorpercentilearray)",
]
0d54b82
to
0601718
Compare
thatzopoulos
force-pushed
the
th/approx-percentile-array-stabilization
branch
from
0601718
to
9d65355
Compare
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"license/cla\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
I just trigged a CLA re-check, this should be able to be merged now. bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #747, we will need a better workaround for this in the future when we make changes to stability checks