Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require exactly one space before or after = #103

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Don't require exactly one space before or after = #103

merged 1 commit into from
Oct 24, 2022

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Aug 29, 2022

My postgresql.conf looks like this:

checkpoint_timeout = 30min   # Max. time between checkpoints; Default: 5min
max_wal_size       = 4GB     # Default: 1G
min_wal_size       = 256MB   # Default: 80M

It would fail to detect these keys as the tuneRegexFmt and
tuneRegexQuotedFmt require exactly " = "; this changes that to "\s*=\s*"
to accept any whitespace. It doesn't make any effort to write these
spaces back – might be nice too, but I couldn't be bothered πŸ˜…

Also use ` for these strings so you don't need to double up the
backslashes.

My postgresql.conf looks like this:

	checkpoint_timeout = 30min   # Max. time between checkpoints; Default: 5min
	max_wal_size       = 4GB     # Default: 1G
	min_wal_size       = 256MB   # Default: 80M

It would fail to detect these keys as the tuneRegexFmt and
tuneRegexQuotedFmt require exactly " = "; this changes that to "\s*=\s*"
to accept any whitespace. It doesn't make any effort to write these
spaces back – might be nice too, but I couldn't be bothered πŸ˜…

Also use ` for these strings so you don't need to double up the
backslashes.
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@svenklemm svenklemm merged commit 681763b into timescale:main Oct 24, 2022
@arp242 arp242 deleted the ws branch October 24, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants