Fix year not multiple of day/month in nested CAgg

Previously all intervals were converted to seconds using "epoch"
with date_part. However, this treats a year as 365.25 days to
account for leap years, leading to the unexpected situation that
a year is not a multiple of a day or a month.

Fixed by treating month-only intervals as multiples of 30 days.

Fixes #5231

CHANGELOG.md

@@ -17,6 +17,7 @@ accidentally triggering the load of a previous DB version.**
 * #5218 Add role-level security to job error log
 * #5214 Fix use of prepared statement in async module
 * #5259 Lock down search_path in SPI calls
+* #5255 Fix year not multiple of day/month in nested CAgg
 
 ## 2.9.2 (2023-01-26)
 

tsl/src/continuous_aggs/create.c

@@ -1113,6 +1113,17 @@ get_bucket_width(CAggTimebucketInfo bucket_info)
 			break;
 		case INTERVALOID:
 		{
+			/*
+			 * epoch will treat year as 365.25 days. This leads to the unexpected
+			 * result that year is not multiple of day or month, which is perceived
+			 * as a bug. For that reason, we treat all months as 30 days regardless of year
+			 */
+			if (bucket_info.interval->month && !bucket_info.interval->day &&
+				!bucket_info.interval->time)
+			{
+				bucket_info.interval->day = bucket_info.interval->month * DAYS_PER_MONTH;
+				bucket_info.interval->month = 0;
+			}
 			Datum epoch = DirectFunctionCall2(interval_part,
 											  PointerGetDatum(cstring_to_text("epoch")),
 											  IntervalPGetDatum(bucket_info.interval));