Skip to content

Commit

Permalink
Make dist_partial_agg output pg version specific
Browse files Browse the repository at this point in the history
The plan output of the dist_partial_agg test is different on PG14
so we need to make it PG version specific. On PG14 sorts are pushed
down more often leading to better plans in some cases.
  • Loading branch information
svenklemm committed Oct 12, 2021
1 parent 8d12b28 commit c421d30
Show file tree
Hide file tree
Showing 7 changed files with 987 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/gh_matrix_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def macos_config(overrides):
"pg": PG14_LATEST,
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=OFF -DEXPERIMENTAL=ON",
"coverage": False,
"installcheck_args": "IGNORES='dist_hypertable-14 dist_partial_agg dist_query'"
"installcheck_args": "IGNORES='dist_hypertable-14 dist_query'"
}
m["include"].append(build_debug_config(pg14_debug_latest))

Expand Down
File renamed without changes.
488 changes: 488 additions & 0 deletions tsl/test/expected/dist_partial_agg-13.out

Large diffs are not rendered by default.

496 changes: 496 additions & 0 deletions tsl/test/expected/dist_partial_agg-14.out

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tsl/test/sql/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
/compression_permissions-*.sql
/hypertable_distributed-*.sql
/dist_hypertable-*.sql
/dist_partial_agg-*.sql
/plan_skip_scan-*.sql
/remote_copy-*.sql
/jit-*.sql
3 changes: 1 addition & 2 deletions tsl/test/sql/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ set(TEST_FILES_DEBUG
dist_compression.sql
dist_ddl.sql
dist_grant.sql
dist_partial_agg.sql
dist_policy.sql
dist_query.sql
dist_util.sql
Expand All @@ -77,7 +76,7 @@ set(TEST_TEMPLATES

if(CMAKE_BUILD_TYPE MATCHES Debug)
list(APPEND TEST_TEMPLATES continuous_aggs_query.sql.in
dist_hypertable.sql.in remote_copy.sql.in)
dist_partial_agg.sql.in dist_hypertable.sql.in remote_copy.sql.in)
endif(CMAKE_BUILD_TYPE MATCHES Debug)

# Check if PostgreSQL was compiled with JIT support
Expand Down
File renamed without changes.

0 comments on commit c421d30

Please sign in to comment.