fixup

.github/workflows/postgres_dev.yaml

@@ -32,7 +32,7 @@ jobs:
         path: ~/${{ env.PG_SRC_DIR }}
         key: ${{ runner.os }}-postgresql-dev-${{ env.PG_COMMIT }}
 
-    - name: Build PostgreSQL ${{ matrix.pg }} ${{ matrix.build_type }}
+    - name: Build PostgreSQL ${{ env.PG_COMMIT }}
       if: steps.cache-postgresql.outputs.cache-hit != 'true'
       run: |
         mkdir -p ~/$PG_SRC_DIR
@@ -58,8 +58,51 @@ jobs:
         make -C build
         make -C build install
 
+    # this is more for informational purposes as we don't yet have pg14 test output files and treat them as being the same as PG13
     - name: Run tests
       run: |
         find . -name '*-13.out' | xargs -IFILE bash -c 'cp FILE $(echo FILE| sed -e "s!-13.out!-14.out!")'
-        make -C build installcheck
+        make -C build installcheck || true
 
+    - name: Show regression diffs
+      if: always()
+      id: collectlogs
+      run: |
+        find . -name regression.diffs -exec cat {} + > regression.log
+        find . -name postmaster.log -exec cat {} + > postgres.log
+        if [[ "${{ runner.os }}" == "Linux" ]] ; then
+          # wait in case there are in-progress coredumps
+          sleep 10
+          if coredumpctl -q list >/dev/null; then echo "::set-output name=coredumps::true"; fi
+        fi
+        if [[ -s regression.log ]]; then echo "::set-output name=regression_diff::true"; fi
+        grep -e 'FAILED' -e 'failed (ignored)' installcheck.log || true
+        cat regression.log
+
+    - name: Save regression diffs
+      if: always() && steps.collectlogs.outputs.regression_diff == 'true'
+      uses: actions/upload-artifact@v2
+      with:
+        name: Regression diff PG ${{ env.PG_COMMIT }}
+        path: regression.log
+
+    - name: Save postmaster.log
+      if: always()
+      uses: actions/upload-artifact@v2
+      with:
+        name: PostgreSQL log PG ${{ env.PG_COMMIT }}
+        path: postgres.log
+
+    - name: Stack trace
+      if: always() && steps.collectlogs.outputs.coredumps == 'true'
+      run: |
+        echo "bt full" | sudo coredumpctl gdb
+        ./scripts/bundle_coredumps.sh
+        false
+
+    - name: Coredumps
+      if: always() && steps.collectlogs.outputs.coredumps == 'true'
+      uses: actions/upload-artifact@v2
+      with:
+        name: Coredumps PG ${{ env.PG_COMMIT }}
+        path: coredumps