Skip to content

Commit

Permalink
Make reorder_vs_insert deterministic
Browse files Browse the repository at this point in the history
Add markers to steps in `reorder_vs_insert` that should be waiting to
prevent non-determinsm when running.
  • Loading branch information
mkindahl committed Jun 20, 2024
1 parent eb3ef90 commit e2089f7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .unreleased/fix_7051
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes: #7051 Make reorder_vs_insert deterministic
2 changes: 1 addition & 1 deletion tsl/test/isolation/expected/reorder_vs_insert.out
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ step Rc: COMMIT;
starting permutation: R1 I1 Ic Bc Rc
step R1: SELECT reorder_chunk_i((SELECT show_chunks('ts_reorder_test') LIMIT 1), 'ts_reorder_test_time_idx', wait_on => 'waiter'); <waiting ...>
step I1: INSERT INTO ts_reorder_test VALUES (1, 19.5, 3); <waiting ...>
step I1: <... completed>
step R1: <... completed>
ERROR: canceling statement due to lock timeout
step I1: <... completed>
step Ic: COMMIT;
step Bc: COMMIT;
step Rc: COMMIT;
Expand Down
4 changes: 2 additions & 2 deletions tsl/test/isolation/specs/reorder_vs_insert.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ step "Bc" { COMMIT; }

permutation "Bc" "I1" "Ic" "R1" "Rc"
permutation "Bc" "I1" "R1" "Ic" "Rc"
permutation "Bc" "I1" "R1" "Rc" "Ic"
permutation "Bc" "I1" "R1"(*) "Rc" "Ic"

permutation "Bc" "R1" "Rc" "I1" "Ic"
permutation "Bc" "R1" "I1" "Rc" "Ic"
permutation "Bc" "R1" "I1" "Ic" "Rc"

permutation "R1" "I1" "Ic" "Bc" "Rc"
permutation "R1" "I1"(R1) "Ic" "Bc" "Rc"
permutation "R1" "I1" "Bc" "Rc" "Ic"
permutation "I1" "R1" "Bc" "Rc" "Ic"

0 comments on commit e2089f7

Please sign in to comment.