Skip to content

Commit

Permalink
Remove check from relcache invalidation callback
Browse files Browse the repository at this point in the history
The timescaledb extension checking code uses syscache lookups to
determine whether the proxy table exists. Doing syscache lookups
inside the invalidation callback context was corrupting the syscache.
For this reason, we remove this callback.
  • Loading branch information
Markos Fountoulakis committed Jul 22, 2021
1 parent 637fe32 commit e8b6b18
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/loader/loader.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,6 @@ ts_loader_extension_exists(void)
return extension_exists();
}

static void
inval_cache_callback(Datum arg, Oid relid)
{
if (guc_disable_load)
return;
extension_check();
}

static bool
drop_statement_drops_extension(DropStmt *stmt)
{
Expand Down Expand Up @@ -573,7 +565,6 @@ _PG_init(void)
* cannot check for extension here since not inside a transaction yet. Nor
* do we even have an assigned database yet
*/
CacheRegisterRelcacheCallback(inval_cache_callback, PointerGetDatum(NULL));

/*
* using the post_parse_analyze_hook since it's the earliest available
Expand Down

0 comments on commit e8b6b18

Please sign in to comment.