Skip to content

Commit

Permalink
Fix typo in chunks view
Browse files Browse the repository at this point in the history
The is_compressed column for timescaledb_information.chunks
view is defined as TEXT instead of BOOLEAN
as true and false were specified using string literals.
  • Loading branch information
gayyappan committed Sep 17, 2020
1 parent c1bd79e commit ffc9999
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions sql/views.sql
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ SELECT
THEN NULL
ELSE dimsl.range_end
END as integer_range_end,
CASE WHEN srcch.compressed_chunk_id is not null THEN 'true'
ELSE 'false'
CASE WHEN srcch.compressed_chunk_id is not null THEN true
ELSE false
END as is_compressed,
pgtab.spcname as chunk_table_space,
chdn.node_list
Expand Down
6 changes: 3 additions & 3 deletions tsl/test/expected/dist_compression.out
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ range_start | Wed Feb 28 16:00:00 2018 PST
range_end | Wed Mar 07 16:00:00 2018 PST
range_start_integer |
range_end_integer |
is_compressed | false
is_compressed | f
chunk_tablespace |
data_nodes | {db_dist_compression_1,db_dist_compression_2}
-[ RECORD 2 ]----------+----------------------------------------------
Expand All @@ -255,7 +255,7 @@ range_start | Wed Feb 28 16:00:00 2018 PST
range_end | Wed Mar 07 16:00:00 2018 PST
range_start_integer |
range_end_integer |
is_compressed | false
is_compressed | f
chunk_tablespace |
data_nodes | {db_dist_compression_2,db_dist_compression_3}
-[ RECORD 3 ]----------+----------------------------------------------
Expand All @@ -269,7 +269,7 @@ range_start | Wed Feb 28 16:00:00 2018 PST
range_end | Wed Mar 07 16:00:00 2018 PST
range_start_integer |
range_end_integer |
is_compressed | false
is_compressed | f
chunk_tablespace |
data_nodes | {db_dist_compression_1,db_dist_compression_3}

Expand Down
6 changes: 3 additions & 3 deletions tsl/test/expected/dist_views.out
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ SELECT * from timescaledb_information.chunks
ORDER BY hypertable_name, chunk_name;
hypertable_schema | hypertable_name | chunk_schema | chunk_name | primary_dimension | primary_dimension_type | range_start | range_end | range_start_integer | range_end_integer | is_compressed | chunk_tablespace | data_nodes
-------------------+-----------------+-----------------------+-----------------------+-------------------+--------------------------+------------------------------+------------------------------+---------------------+-------------------+---------------+------------------+---------------------------
public | dist_table | _timescaledb_internal | _dist_hyper_1_1_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | false | | {view_node_1,view_node_2}
public | dist_table | _timescaledb_internal | _dist_hyper_1_2_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | false | | {view_node_2,view_node_3}
public | dist_table | _timescaledb_internal | _dist_hyper_1_3_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | false | | {view_node_1,view_node_3}
public | dist_table | _timescaledb_internal | _dist_hyper_1_1_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | f | | {view_node_1,view_node_2}
public | dist_table | _timescaledb_internal | _dist_hyper_1_2_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | f | | {view_node_2,view_node_3}
public | dist_table | _timescaledb_internal | _dist_hyper_1_3_chunk | time | timestamp with time zone | Wed Feb 28 16:00:00 2018 PST | Wed Mar 07 16:00:00 2018 PST | | | f | | {view_node_1,view_node_3}
(3 rows)

SELECT * from timescaledb_information.dimensions
Expand Down

0 comments on commit ffc9999

Please sign in to comment.