Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal now() returns system clock time instead of transaction time #2167

Closed
erimatnor opened this issue Jul 31, 2020 · 0 comments
Closed
Assignees
Labels
2.0-proposed Proposed for 2.0.0 release bug
Milestone

Comments

@erimatnor
Copy link
Contributor

In short: ts_get_now_internal uses GetCurrentTime() as its standard time function. This returns system clock instead of the transaction timestamp, which means that the time will vary between each call to this function within the same transaction. Note that the standard now() function returns transaction time, so our internal time function departs from the standard. This can affect queries and other things that rely on getting a consistent time for a transaction.

@erimatnor erimatnor added bug 2.0-proposed Proposed for 2.0.0 release labels Jul 31, 2020
@erimatnor erimatnor added this to the 2.0.0 milestone Jul 31, 2020
@pmwkaa pmwkaa self-assigned this Aug 20, 2020
pmwkaa added a commit to pmwkaa/timescaledb that referenced this issue Aug 20, 2020
pmwkaa added a commit to pmwkaa/timescaledb that referenced this issue Aug 31, 2020
pmwkaa added a commit to pmwkaa/timescaledb that referenced this issue Aug 31, 2020
pmwkaa added a commit that referenced this issue Aug 31, 2020
@pmwkaa pmwkaa closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-proposed Proposed for 2.0.0 release bug
Projects
None yet
Development

No branches or pull requests

2 participants