Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in chunks view #2410

Merged
merged 1 commit into from Sep 17, 2020
Merged

Fix typo in chunks view #2410

merged 1 commit into from Sep 17, 2020

Conversation

gayyappan
Copy link
Contributor

The is_compressed column for timescaledb_information.chunks
view is defined as TEXT instead of BOOLEAN
as true and false were specified using string literals.

@gayyappan gayyappan requested a review from a team as a code owner September 17, 2020 19:51
@gayyappan gayyappan requested review from pmwkaa, k-rus, WireBaron and svenklemm and removed request for a team September 17, 2020 19:51
@k-rus
Copy link
Contributor

k-rus commented Sep 17, 2020

It seems that tests have failed.

@k-rus
Copy link
Contributor

k-rus commented Sep 17, 2020

@gayyappan can you link the commit message to the issue Sven created, so it will close it on merge?

The is_compressed column for timescaledb_information.chunks
view is defined as TEXT instead of BOOLEAN
as true and false were specified using string literals.

Fixes timescale#2409
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2410 into master will increase coverage by 1.16%.
The diff coverage is 98.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2410      +/-   ##
==========================================
+ Coverage   88.91%   90.08%   +1.16%     
==========================================
  Files         212      213       +1     
  Lines       34788    34300     -488     
==========================================
- Hits        30932    30899      -33     
+ Misses       3856     3401     -455     
Impacted Files Coverage Δ
src/catalog.c 84.70% <ø> (ø)
src/catalog.h 100.00% <ø> (ø)
src/cross_module_fn.c 58.13% <ø> (+1.32%) ⬆️
src/hypertable.c 87.42% <ø> (-0.08%) ⬇️
tsl/src/continuous_aggs/insert.c 87.23% <ø> (+0.15%) ⬆️
tsl/src/continuous_aggs/materialize.c 66.00% <ø> (+52.70%) ⬆️
tsl/src/init.c 88.88% <ø> (ø)
src/process_utility.c 93.59% <88.88%> (-0.05%) ⬇️
src/chunk.c 95.31% <100.00%> (-0.01%) ⬇️
src/continuous_agg.c 93.50% <100.00%> (+4.18%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21839d...2a02c7a. Read the comment docs.

@gayyappan gayyappan merged commit 149d452 into timescale:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants