Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PG11 #3285

Merged
merged 5 commits into from Jun 1, 2021
Merged

Remove support for PG11 #3285

merged 5 commits into from Jun 1, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented May 27, 2021

Disable-check: commit-count

@svenklemm svenklemm requested a review from a team as a code owner May 27, 2021 07:23
@svenklemm svenklemm requested review from erimatnor, mkindahl and gayyappan and removed request for a team May 27, 2021 07:23
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #3285 (b114df2) into master (9fe90eb) will increase coverage by 0.15%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
+ Coverage   90.34%   90.50%   +0.15%     
==========================================
  Files         216      212       -4     
  Lines       36030    35494     -536     
==========================================
- Hits        32553    32124     -429     
+ Misses       3477     3370     -107     
Impacted Files Coverage Δ
src/chunk.c 95.91% <ø> (-0.01%) ⬇️
src/chunk_append/chunk_append.c 97.41% <ø> (-0.04%) ⬇️
src/chunk_append/exec.c 95.84% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (ø)
src/chunk_append/transform.c 96.66% <ø> (ø)
src/compat.h 100.00% <ø> (ø)
src/constraint.c 69.56% <ø> (ø)
src/debug_guc.c 92.63% <ø> (ø)
src/dimension_slice.c 93.33% <ø> (+0.24%) ⬆️
src/estimate.c 87.12% <ø> (ø)
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe90eb...b114df2. Read the comment docs.

@svenklemm svenklemm force-pushed the drop_pg11 branch 2 times, most recently from 4833382 to 9c29435 Compare May 27, 2021 08:59
Copy link
Contributor

@pmwkaa pmwkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw several opportunities for optimization that you didn't do, which made my job as a reviewer a lot easier, so thank you for that.

scripts/gh_matrix_builder.py Outdated Show resolved Hide resolved
src/compat.h Outdated Show resolved Hide resolved
tsl/src/nodes/gapfill/exec.c Show resolved Hide resolved
@svenklemm svenklemm force-pushed the drop_pg11 branch 2 times, most recently from b21feec to 09db9d2 Compare June 1, 2021 13:13
Remove all CI runs against postgres 11
Remove support for compiling against PostgreSQL 11. This patch also
removes PG11 specific compatibility macros.
Merge test files that after the removal of PG11 support need
to be no longer version specific.
Remove update files that were only used for PG11 versions since
those versions do not support postgres past PG11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants