Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG12 removal : Cleanup test files and update files #5865

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Jul 7, 2023

Follow up to #5863
Removes a bunch PG12 sepcific testfiles and updates.
PG12 macros still remain. They will be removed in another followup.

Disable-check: force-changelog-file
Disable-check: commit-count

As PG12 support has been now removed, merge testfiles that were split
out due to their output differing only in PG12.
As PG12 is not supported anymore, remove the update files that were
used only for PG12.
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #5865 (c03df87) into main (eaa1206) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5865      +/-   ##
==========================================
- Coverage   87.88%   87.05%   -0.83%     
==========================================
  Files         239      239              
  Lines       55792    55691     -101     
  Branches    12359    12326      -33     
==========================================
- Hits        49031    48483     -548     
+ Misses       4867     4851      -16     
- Partials     1894     2357     +463     

see 103 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello
Copy link
Contributor

Just for curiosity, why another PR and not several commits into the previous PR? We did it removing the PG11 support - #3285

@lkshminarayanan
Copy link
Contributor Author

Just for curiosity, why another PR and not several commits into the previous PR? We did it removing the PG11 support - #3285

I was planning to get #5863 approved and merged independent of code + file cleanup changes. Hence the separate PRs. But now it looks like the code + file cleanup changes are not that big as I thought, so your suggestion is better. I'll close this one and add all the commits to #5863.

@lkshminarayanan lkshminarayanan deleted the pg12-removal-file-cleanup branch July 7, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants