Add workflow to test PG14 #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
afiskon,
nikkhils and
mfundul
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #3349 +/- ##
==========================================
- Coverage 90.61% 90.59% -0.03%
==========================================
Files 212 212
Lines 35588 35592 +4
==========================================
- Hits 32248 32243 -5
- Misses 3340 3349 +9
Continue to review full report at Codecov.
|
mkindahl
reviewed
Jun 23, 2021
| @@ -96,6 +96,7 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | |||
|
|
|||
| # Code coverage is optional and OFF by default | |||
| option(CODECOVERAGE "Enable code coverage for the build" OFF) | |||
| option(EXPERIMENTAL "Skip postgres version compatibility check" OFF) | |||
There was a problem hiding this comment.
... or DEVELOPMENT. No opinion, just offering alternatives.
gayyappan
approved these changes
Jun 23, 2021
svenklemm
force-pushed
the
pg14_workflow
branch
4 times, most recently
from
e30553d
to
e5db993
Compare
This patch adds a new EXPERIMENTAL flag to cmake allowing skipping the check for a compatible postgres version. It also adds macros needed for PG14 support.
PG14 renames field relkind for CreateTableAsStmt and AlterTableStmt to objtype. postgres/postgres@cc35d8933a
PG14 changes xact.h to no longer include fmgr.h which is needed for PG_FUNCTION_ARGS definition. This patch includes fmgr.h explicitly to no longer rely on the indirect include. postgres/postgres@3941eb6341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: commit-count