Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory overflow #3355

Merged
merged 1 commit into from Jun 23, 2021
Merged

Fix memory overflow #3355

merged 1 commit into from Jun 23, 2021

Conversation

mfundul
Copy link
Contributor

@mfundul mfundul commented Jun 23, 2021

Fix heap buffer overflow when renaming compressed hypertable columns.

Fixes #3354

@mfundul mfundul requested review from mkindahl, gayyappan, a team and svenklemm and removed request for a team June 23, 2021 07:46
@mfundul mfundul self-assigned this Jun 23, 2021
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #3355 (259382d) into master (001f5d9) will decrease coverage by 1.58%.
The diff coverage is 88.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3355      +/-   ##
==========================================
- Coverage   92.17%   90.58%   -1.59%     
==========================================
  Files         110      212     +102     
  Lines       14177    35589   +21412     
==========================================
+ Hits        13067    32240   +19173     
- Misses       1110     3349    +2239     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk.h 100.00% <ø> (ø)
src/chunk_adaptive.c 92.57% <ø> (+2.78%) ⬆️
src/chunk_append/chunk_append.c 97.41% <ø> (+0.90%) ⬆️
src/chunk_append/exec.c 95.84% <ø> (+1.66%) ⬆️
src/chunk_append/explain.c 82.81% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (-2.27%) ⬇️
src/chunk_append/transform.c 96.66% <ø> (-3.34%) ⬇️
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82b5c3...259382d. Read the comment docs.

Copy link
Contributor

@erimatnor erimatnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW, I do think that these issues are mostly false positives because the analyzer cannot know that the passed in string already conforms to to the length limitations. For the future, perhaps we should actually change the signature of the such functions to take Name pointers instead?

@mfundul
Copy link
Contributor Author

mfundul commented Jun 23, 2021

This is not a false positive. The Address Sanitizer has injected instrumentation code during compilation and the usage of directly-mapped shadow memory (See here). What happens is that at runtime memcpy() actually accesses memory outside of malloc()ed regions, be it loads or stores, and ASAN will always catch those.

Fix heap buffer overflow when renaming compressed hypertable columns.
@mfundul mfundul requested a review from a team as a code owner June 23, 2021 10:32
@mfundul mfundul merged commit a5caa55 into timescale:master Jun 23, 2021
@mfundul mfundul deleted the fix-memory-overflow branch June 23, 2021 10:51
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
@mkindahl mkindahl mentioned this pull request Jul 1, 2021
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 1, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit that referenced this pull request Jul 2, 2021
**Bugfixes**
* #3279 Add some more randomness to chunk assignment
* #3288 Fix failed update with parallel workers
* #3300 Improve trigger handling on distributed hypertables
* #3304 Remove paths that reference parent relids for compressed chunks
* #3305 Fix pull_varnos miscomputation of relids set
* #3310 Generate downgrade script
* #3314 Fix heap buffer overflow in hypertable expansion
* #3317 Fix heap buffer overflow in remote connection cache.
* #3327 Make aggregate in caggs fully qualified
* #3327 Make aggregates in caggs fully qualified
* #3336 Fix pg_init_privs objsubid handling
* #3345 Fix SkipScan distinct column identification
* #3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* #3367 Improve DecompressChunk qual pushdown
* #3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 2, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit to mkindahl/timescaledb that referenced this pull request Jul 5, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* timescale#3279 Add some more randomness to chunk assignment
* timescale#3288 Fix failed update with parallel workers
* timescale#3300 Improve trigger handling on distributed hypertables
* timescale#3304 Remove paths that reference parent relids for compressed chunks
* timescale#3305 Fix pull_varnos miscomputation of relids set
* timescale#3310 Generate downgrade script
* timescale#3314 Fix heap buffer overflow in hypertable expansion
* timescale#3317 Fix heap buffer overflow in remote connection cache.
* timescale#3327 Make aggregate in caggs fully qualified
* timescale#3327 Make aggregates in caggs fully qualified
* timescale#3336 Fix pg_init_privs objsubid handling
* timescale#3345 Fix SkipScan distinct column identification
* timescale#3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* timescale#3367 Improve DecompressChunk qual pushdown
* timescale#3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
mkindahl added a commit that referenced this pull request Jul 6, 2021
This maintenance release contains bugfixes since the 2.3.0 release. We
deem it moderate priority for upgrading. The release introduces the
possibility of generating downgrade scripts, improves the trigger
handling for distributed hypertables, adds some more randomness to
chunk assignment to avoid thundering herd issues in chunk assignment,
and fixes some issues in update handling as well as some other bugs.

**Bugfixes**
* #3279 Add some more randomness to chunk assignment
* #3288 Fix failed update with parallel workers
* #3300 Improve trigger handling on distributed hypertables
* #3304 Remove paths that reference parent relids for compressed chunks
* #3305 Fix pull_varnos miscomputation of relids set
* #3310 Generate downgrade script
* #3314 Fix heap buffer overflow in hypertable expansion
* #3317 Fix heap buffer overflow in remote connection cache.
* #3327 Make aggregate in caggs fully qualified
* #3327 Make aggregates in caggs fully qualified
* #3336 Fix pg_init_privs objsubid handling
* #3345 Fix SkipScan distinct column identification
* #3355 Fix heap buffer overflow when renaming compressed hypertable columns.
* #3367 Improve DecompressChunk qual pushdown
* #3377 Fix bad use of repalloc

**Thanks**
* @db-adrian for reporting an issue when accessing cagg view through postgres_fdw
* @fncaldas and @pgwhalen for reporting an issue accessing caggs when public is not in search_path
* @fvannee, @mglonnro and @ebreijo for reporting an issue with the upgrade script
* @fvannee for reporting a performance regression with SkipScan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory overflow
4 participants